Re: [Rails-devel] Automated testing

[Erik V. <eri...@xs...>]

See below.

> -----Original Message-----
> From: Stefan Frey [mailto:ste...@we...]
 
> Regarding the failed tests from your phase changes they show that
> A) Phase names in 1856 changed

Ah yes, I should have reported that. With my latest commit I have also
renamed all (distinct) phases after the last bought train, where that wasn't
the case, deferring the "real" (but not always usable) phase names to the
new "realName" attribute that I have added recently (and is now shown in
square brackets in the UI).  I think I now did 1856 and 1870, 1835 had been
done before (and 1880 by Martin). Not done 1825.
 
> B) All messages "train obsolete" were removed from 1830_A (C&R variant).
> 
> C) All messages "train rusted" were removed from both games 1889 and
> 18AL_A.
> 
> D) 18EU_A surprisingly kept the train rusted messages, but lost the
message
> "TrainsAvailable,P".
> 
> It seems that A) was an intended change, for B) to D) I am not so sure.
> Maybe you should check this.

Nothing was intentional, I had just forgotten to put these report lines into
the new code.
The message "All X-trains are sold out, Y-trains now available" wasn't even
localised, and had to be split into two lines, because the second half is
now displayed on a separate line in *all* cases where a new type becomes
available. So I have added a new "TrainsSoldOut" entry.

To check any differences, I would like to be able to compare the old and new
TE_ST reports line by line in a tool like WinMerge.  Are the new reports
saved anywhere?  If not, wouldn't that be a useful addition, or have you
already made that possible in another way?

Erik