Re: [Rails-devel] Code review tools [was: 1880 Patch]

[John A. T. <ja...@ja...>]

On Sun, Jul 24, 2011 at 7:39 AM, Erik Vos <eri...@xs...> wrote:

> ‘Rietveld’ seems to be intended for SVN projects. A similar tool exists for
> Git named ‘Gerrit’.  Egit supports it.****
>
> **
>

Yes, sorry -- I forgot that it needs the repository to be svn.  We have
people using it with git, and the upload code understands git clients
(whether from svn or our internal repository which is mirrored to svn).


> I don’t have an opinion right now on whether or not we need such a tool.
>  Sounds to me a bit like overkill, but I may be wrong.
>

If you spend any time at all looking at patches, you will prefer to look at
them in something like Rietveld.  Even if you never want to do
review-before-commit, it is just more convenient to see them there.

-- 
John A. Tamplin