[Rails-devel] Code review tools [was: 1880 Patch]

[Erik V. <eri...@xs...>]

‘Rietveld’ seems to be intended for SVN projects. A similar tool exists for Git named ‘Gerrit’.  Egit supports it.

 

I don’t have an opinion right now on whether or not we need such a tool.  Sounds to me a bit like overkill, but I may be wrong.

 

The names are interesting, though. Both apparently refer to the same person: the Dutch designer/architect Gerrit Rietveld (1888-1964).

And the Rietveld site says that the tool of that name was based on Mondrian, named after another Dutch artist.

 

That gives me a good feeling… :-)

 

Erik.

 

From: John A. Tamplin [mailto:ja...@ja...] 
Sent: Sunday, July 24, 2011 7:55 AM
To: Development list for Rails: an 18xx game
Subject: Re: [Rails-devel] 1880 Patch

 

On Sat, Jul 23, 2011 at 4:03 PM, Erik Vos <eri...@xs...> wrote:

The git patch I had created for myself in Egit did have header info.  As it had my full commit text as a Subject, I must have created it from a committed change.

Martin, did you perhaps create your git patch from a working copy?
And do you have set up .gitconfig with at least your name and mail address?

 

Speaking of uploading patches / code reviews, is there any interest in using something like Rietveld <http://code.google.com/p/rietveld/> ?  You can see it in action at http://codereview.appspot.com/4817048/diff/3001/lily/slur-configuration.cc

 

If you are interested, it is trivial to setup an AppEngine instance for free and run one dedicated to Rails.


-- 
John A. Tamplin