Re: [Rails-devel] 1880 Patch

[John A. T. <ja...@ja...>]

On Sat, Jul 23, 2011 at 4:03 PM, Erik Vos <eri...@xs...> wrote:

> The git patch I had created for myself in Egit did have header info.  As it
> had my full commit text as a Subject, I must have created it from a
> committed change.
>
> Martin, did you perhaps create your git patch from a working copy?
> And do you have set up .gitconfig with at least your name and mail address?


Speaking of uploading patches / code reviews, is there any interest in using
something like Rietveld <http://code.google.com/p/rietveld/>?  You can see
it in action at
http://codereview.appspot.com/4817048/diff/3001/lily/slur-configuration.cc

If you are interested, it is trivial to setup an AppEngine instance for free
and run one dedicated to Rails.

-- 
John A. Tamplin