Re: [Rails-devel] [Rails-commits] rails/common

[Erik V. <eri...@xs...>]

> -----Original Message-----
> From: brett lentz [mailto:bre...@gm...]
> My thinking is that two back-to-back if-statements that are checking the
> same condition is redundant and unnecessary. You've checked the condition
> once and have a code block for it. There's no need to do the exact same
> check again immediately afterward. 

Unless the condition may have changed in the meantime, which can be the case here if the first check is still needed at all.  

I'll check what the effect of removing it will be, and if it's harmless to my many old save files, I'll remove that code.

Erik.