Re: [Rails-devel] [Rails-commits] rails/common

[Erik V. <eri...@xs...>]

Brett,

I don't think this is a good change, because 'optionValue' may have been
assigned between the first and the second identical ifs.
This second if    [  if (optionValue == null) ]  should be read as: if
optionValue is *still* null, then...

Erik.

> -----Original Message-----
> From: Brett Lentz [mailto:wak...@us...]
> Sent: Thursday, July 21, 2011 7:02 PM
> To: rai...@li...
> Subject: [Rails-commits] rails/common
> 
>  rails/common/parser/Tag.java |    3 ---
>  1 file changed, 3 deletions(-)
> 
> New commits:
> commit 6b7255acdcdfd3217884ae2701975166df7350b8
> Author: Brett Lentz <bl...@cl...>
> Date:   Thu Jul 21 09:58:42 2011 -0700
> 
>     Tag: simplify conditional logic.
> 
>     This is really a spurious commit to test Egit.
> 
> diff --git a/rails/common/parser/Tag.java b/rails/common/parser/Tag.java
> index 22c3c0a..7a7d46e 100644
> --- a/rails/common/parser/Tag.java
> +++ b/rails/common/parser/Tag.java
> @@ -326,9 +326,6 @@ public class Tag {
>                      			break;
>                      		}
>                      	}
> -                    }
> -
> -                    if (optionValue == null) {
>                          // Take the default value
>                          GameOption go = GameOption.getByName(name);
>                          optionValue = go != null ? go.getDefaultValue() :
"";
> 
> 
> 
>
----------------------------------------------------------------------------
--
> 5 Ways to Improve & Secure Unified Communications Unified
> Communications promises greater efficiencies for business. UC can improve
> internal communications as well as offer faster, more efficient ways to
> interact with customers and streamline customer service. Learn more!
> http://www.accelacomm.com/jaw/sfnl/114/51426253/
> _______________________________________________
> Rails-commits mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-commits