Re: [Rails-devel] Game Notes (was: Git repository is now available.)

[Stefan F. <ste...@we...>]

Brett,
back to Rails issues:

* The game notes show up again, but new game still stops with 
NullPointerException errors. It occurs only if the option pane is expanded. 
18xx log reports that the options are not set correctly.

* The automated game tests work again but only for the first. The second and 
following runs fail automatically with Java exceptions, as the static class 
variables inside Token are not initialized again (this is especially true for 
TokenMap).
Do you still intend to fix that or do you prefer to let me have a look at this 
as you already have to cope with my mistakes with git? Fixing the automated 
tests has a  high priority on my todo list.

Stefan

On Tuesday, July 19, 2011 10:28:28 pm brett lentz wrote:
> Ah. Now I see where it was lost.
> 
> Apologies for the oversight. The fix has been committed.
> 
> ---Brett.
> 
> On Tue, Jul 19, 2011 at 12:20 PM, Erik Vos <eri...@xs...> wrote:
> > I think it is all explained by the fact that your GameInfoParser does not
> > parse <Note>. Erik.
> > 
> >> -----Original Message-----
> >> From: brett lentz [mailto:bre...@gm...]
> >> Sent: Monday, July 18, 2011 11:54 PM
> >> To: Development list for Rails: an 18xx game
> >> Subject: Re: [Rails-devel] Game Notes (was: Git repository is now
> >> available.)
> >> 
> >> Erik -
> >> 
> >> Looking over my commit history, I don't see a call to setNote() in any
> >> of the diffs.
> >> 
> >> I see where I moved GameInfo into rails.common.parser. GameInfo still
> >> has the setNote() method, but I can't locate any calls to it.
> >> 
> >> ---Brett.
> >> 
> >> 
> >> 
> >> On Mon, Jul 18, 2011 at 12:03 PM, brett lentz <bre...@gm...>
> >> 
> >> wrote:
> >> > Hrm... I'd swear I moved that call into the new constructor. It was
> >> > working when I last tested it.
> >> > 
> >> > I'll check it out and see what went wrong.
> >> > 
> >> > ---Brett.
> >> > 
> >> > On Mon, Jul 18, 2011 at 11:50 AM, Erik Vos <eri...@xs...> wrote:
> >> >> Brett,
> >> >> 
> >> >> I think this is caused by your refactoring of game info parsing.
> >> >> GameInfo.setNote() is no longer called, so all notes stay at the
> >> >> default value "Notes".  You seem to have overlooked <Note> in your
> >> >> new
> >> 
> >> parser.
> >> 
> >> >> Erik.
> >> >> 
> >> >>> -----Original Message-----
> >> >>> From: Phil Davies [mailto:de...@gm...]
> >> >>> Sent: Monday, July 18, 2011 1:51 PM
> >> >>> To: Development list for Rails: an 18xx game
> >> >>> Subject: Re: [Rails-devel] Git repository is now available.
> >> >>> 
> >> >>> Something strange in the version checked out from Git.  On the
> >> >>> available games dialogue at startup, each game just ahs the word
> >> >>> 'Notes' next to it, rather than the previous designation of
> >> >>> 'playable,
> >> 
> >> unplayable' etc.
> >> 
> >> >> ---------------------------------------------------------------------
> >> >> ---------
> >> >> Storage Efficiency Calculator
> >> >> This modeling tool is based on patent-pending intellectual property
> >> >> that has been used successfully in hundreds of IBM storage
> >> >> optimization engage- ments, worldwide.  Store less, Store more with
> >> >> what you own, Move data to the right place. Try It Now!
> >> >> http://www.accelacomm.com/jaw/sfnl/114/51427378/
> >> >> _______________________________________________
> >> >> Rails-devel mailing list
> >> >> Rai...@li...
> >> >> https://lists.sourceforge.net/lists/listinfo/rails-devel
> >> 
> >> ------------------------------------------------------------------------
> >> ------ Storage Efficiency Calculator
> >> This modeling tool is based on patent-pending intellectual property that
> >> has been used successfully in hundreds of IBM storage optimization
> >> engage- ments, worldwide.  Store less, Store more with what you own,
> >> Move data to the right place. Try It Now!
> >> http://www.accelacomm.com/jaw/sfnl/114/51427378/
> >> _______________________________________________
> >> Rails-devel mailing list
> >> Rai...@li...
> >> https://lists.sourceforge.net/lists/listinfo/rails-devel
> > 
> > -------------------------------------------------------------------------
> > ----- Magic Quadrant for Content-Aware Data Loss Prevention
> > Research study explores the data loss prevention market. Includes
> > in-depth analysis on the changes within the DLP market, and the criteria
> > used to evaluate the strengths and weaknesses of these DLP solutions.
> > http://www.accelacomm.com/jaw/sfnl/114/51385063/
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> 
> ---------------------------------------------------------------------------
> --- Magic Quadrant for Content-Aware Data Loss Prevention
> Research study explores the data loss prevention market. Includes in-depth
> analysis on the changes within the DLP market, and the criteria used to
> evaluate the strengths and weaknesses of these DLP solutions.
> http://www.accelacomm.com/jaw/sfnl/114/51385063/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel