Re: [Rails-devel] Refactored loading code

[Stefan F. <ste...@we...>]

This seems like duplication of work: The repository already keeps a history of 
the change-logs. I believe it will be the same for git. Thus I am reluctant to 
copy the logs into the wiki manually.

What I think would be helpful (and I did that once already) to attach the 
revision number after the e-mail accompanying the commit (if there is any).
In combination with blame this would really help to find out, what was the 
idea behind the change. I quite often search the Rails archive for more info 
of a change.

I have not checked if there is a revision number of the sf-git repository and 
potentially it might be better to copy the main parts of the e-mail into  
(additional) javadoc document(s).

Instead of adding the history of development to the wiki I suggest to add a 
development roadmap/todo-list to the wiki.
Especially with local repositories it gets more likely that several people are 
working on the same stuff, which is both a waste of resources and makes code 
merging difficult. And it might even attract new people, if they know where to 
start and what is needed.

Stefan



> 
> As you may or may not have noticed, since some time I'm pretty meticulously
> creating entries in the Wiki Change Log for all my commits (except very
> trivial ones).  I don't know if I can expect the same from Brett and you
> (as we have seen earlier today, I'm not really the right person to request
> discipline). In any case, I have just created simple entries for the
> recent commits 1602-1604 by the two of you.  Feel free to  correct or
> expand.
> 
> 
> > -----Oorspronkelijk bericht-----
> > Van: Stefan Frey [mailto:ste...@we...]
> > Verzonden: dinsdag 5 juli 2011 19:11
> > Aan: 'Development list for Rails: an 18xx game'
> > Onderwerp: [Rails-devel] Refactored loading code
> > 
> > Brett & Erik,
> > some time ago I started to refactor the game loading code in one class to
> 
> get
> 
> > the ListAndFixSavedFiles utility adjusted to the new comments.
> > 
> > To avoid more incompatibilities from the started refactoring from Brett
> 
> now I
> 
> > thought to adjust the code to include the new reload functionality of
> > Erik
> 
> to
> 
> > be able to commit those changes.
> > 
> > Nearly all loading functionality has been moved to a new GameLoader class
> 
> in
> 
> > rails.util package. The load function in Game, GameManager and
> > ListAndFixSavedFiles now all make use of a a GameLoader object.
> > 
> > I have also added a line to the reload error message that asks the user
> > to submit the corrupt save file to the Rails user list for bug tracking.
> > If
> 
> you think
> 
> > that is not a good idea, simply remove that text from
> > LocalisedProperties.
> > 
> > Stefan
> 
> ---------------------------------------------------------------------------
> - --
> 
> > All of the data generated in your IT infrastructure is seriously
> > valuable. Why? It contains a definitive record of application
> > performance, security threats, fraudulent activity, and more. Splunk
> > takes this data and makes sense of it. IT sense. And common sense.
> > http://p.sf.net/sfu/splunk-d2d-c2
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> 
> ---------------------------------------------------------------------------
> --- All of the data generated in your IT infrastructure is seriously
> valuable. Why? It contains a definitive record of application performance,
> security threats, fraudulent activity, and more. Splunk takes this data
> and makes sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-d2d-c2
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel