Re: [Rails-devel] Refactored loading code

[Erik V. <eri...@xs...>]

This makes me raise another question that has been on my mind for a long
time: should we partially refactor the rails.game package into smaller
subpackages?
Examples: rails.game.round for all Round (sub)classes, rails.game.train,
rails.game.map (hexes and tiles), perhaps others.  

I don't have strong feelings about it, it's just that rails.game is growing
a bit largish.

Erik.

> -----Oorspronkelijk bericht-----
> Van: brett lentz [mailto:bre...@gm...]
> Verzonden: dinsdag 5 juli 2011 19:39
> Aan: Development list for Rails: an 18xx game
> Onderwerp: Re: [Rails-devel] Refactored loading code
> 
> That looks good to me.
> 
> My overall goal with my refactoring is to remove the need for the
rails.game
> package to know about lower-level details, such as XML parsing.
> 
> Moving the classes that need to know about how to load/save game files
> outside of rails.game.* aligns very well with this goal. :-)
> 
> ---Brett.
> 
> 
> 
> On Tue, Jul 5, 2011 at 10:11 AM, Stefan Frey <ste...@we...> wrote:
> > Brett & Erik,
> > some time ago I started to refactor the game loading code in one class
> > to get the ListAndFixSavedFiles utility adjusted to the new comments.
> >
> > To avoid more incompatibilities from the started refactoring from
> > Brett now I thought to adjust the code to include the new reload
> > functionality of Erik to be able to commit those changes.
> >
> > Nearly all loading functionality has been moved to a new GameLoader
> > class in rails.util package. The load function in Game, GameManager
> > and ListAndFixSavedFiles now all make use of a a GameLoader object.
> >
> > I have also added a line to the reload error message that asks the
> > user to submit the corrupt save file to the Rails user list for bug
> > tracking. If you think that is not a good idea, simply remove that
> > text from LocalisedProperties.
> >
> > Stefan
> >
> 
>
----------------------------------------------------------------------------
--
> All of the data generated in your IT infrastructure is seriously valuable.
> Why? It contains a definitive record of application performance, security
> threats, fraudulent activity, and more. Splunk takes this data and makes
> sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-d2d-c2
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel