Menu
▾
▴
Re: [Rails-devel] Refactored loading code
|
From: Erik V. <eri...@xs...> - 2011-07-06 09:04:37
|
I can report that even Autosave/load still works (as far as it ever did). But, as I have not got any feedback yet on this new feature, its further development doesn't have a high priority for me right now. Erik. > -----Oorspronkelijk bericht----- > Van: Stefan Frey [mailto:ste...@we...] > Verzonden: woensdag 6 juli 2011 7:45 > Aan: Development list for Rails: an 18xx game > Onderwerp: Re: [Rails-devel] Refactored loading code > > Further steps on refactoring: > > There is a new class that combines all fields required for gameIO into > rails.util.gameData and renamed the gameLoader into gameFileIO as it now > combines load and save functions. > > Please do some further checks on your own that load and save still works as > intended in all situations. > > One little bit is still missing: ListAndFixSavedFile is not able to save games > currently, only loading. > > Stefan > > On Tuesday, July 05, 2011 07:59:49 pm brett lentz wrote: > > I was actually thinking something similar this weekend... > > > > No objections here. :-) > > > > ---Brett. > > > > On Tue, Jul 5, 2011 at 10:49 AM, Erik Vos <eri...@xs...> wrote: > > > Ah, good stuff. I was already occasionally running into problems > > > with loading files into ListAndFixSavedFiles. > > > > > > As you may or may not have noticed, since some time I'm pretty > > > meticulously creating entries in the Wiki Change Log for all my > > > commits (except very trivial ones). I don't know if I can expect > > > the same from Brett and you (as we have seen earlier today, I'm not > > > really the right person to request discipline). In any case, I have > > > just created simple entries for the recent commits 1602-1604 by the > > > two of you. Feel free to correct or expand. > > > > > > As for packaging, I would prefer to reserve rails.util for Rails > > > classes only, and put all external main programs into tools. That > > > would mean that ListAndFixSavedFiles should move from rails.util to > > > tools. Any objections? > > > > > > I just noticed that we have TWO Util classes, one in rails.util and > > > one in tools. Does anyone know a good reason for that duplication? > > > Otherwise I would propose to merge the two into rails.util.Util. > > > > > > Erik. > > > > > >> -----Oorspronkelijk bericht----- > > >> Van: Stefan Frey [mailto:ste...@we...] > > >> Verzonden: dinsdag 5 juli 2011 19:11 > > >> Aan: 'Development list for Rails: an 18xx game' > > >> Onderwerp: [Rails-devel] Refactored loading code > > >> > > >> Brett & Erik, > > >> some time ago I started to refactor the game loading code in one > > >> class to > > > > > > get > > > > > >> the ListAndFixSavedFiles utility adjusted to the new comments. > > >> > > >> To avoid more incompatibilities from the started refactoring from > > >> Brett > > > > > > now I > > > > > >> thought to adjust the code to include the new reload functionality > > >> of Erik > > > > > > to > > > > > >> be able to commit those changes. > > >> > > >> Nearly all loading functionality has been moved to a new GameLoader > > >> class > > > > > > in > > > > > >> rails.util package. The load function in Game, GameManager and > > >> ListAndFixSavedFiles now all make use of a a GameLoader object. > > >> > > >> I have also added a line to the reload error message that asks the > > >> user to submit the corrupt save file to the Rails user list for bug > > >> tracking. If > > > > > > you think > > > > > >> that is not a good idea, simply remove that text from > > >> LocalisedProperties. > > >> > > >> Stefan > > > > > > -------------------------------------------------------------------- > > > ----- > > > --- -- > > > > > >> All of the data generated in your IT infrastructure is seriously > > >> valuable. Why? It contains a definitive record of application > > >> performance, security threats, fraudulent activity, and more. > > >> Splunk takes this data and makes sense of it. IT sense. And common > sense. > > >> http://p.sf.net/sfu/splunk-d2d-c2 > > >> _______________________________________________ > > >> Rails-devel mailing list > > >> Rai...@li... > > >> https://lists.sourceforge.net/lists/listinfo/rails-devel > > > > > > -------------------------------------------------------------------- > > > ----- > > > ----- All of the data generated in your IT infrastructure is > > > seriously valuable. Why? It contains a definitive record of > > > application performance, security threats, fraudulent activity, and > > > more. Splunk takes this data and makes sense of it. IT sense. And > common sense. > > > http://p.sf.net/sfu/splunk-d2d-c2 > > > _______________________________________________ > > > Rails-devel mailing list > > > Rai...@li... > > > https://lists.sourceforge.net/lists/listinfo/rails-devel > > > > ---------------------------------------------------------------------- > > ----- > > --- All of the data generated in your IT infrastructure is seriously > > valuable. Why? It contains a definitive record of application > > performance, security threats, fraudulent activity, and more. Splunk > > takes this data and makes sense of it. IT sense. And common sense. > > http://p.sf.net/sfu/splunk-d2d-c2 > > _______________________________________________ > > Rails-devel mailing list > > Rai...@li... > > https://lists.sourceforge.net/lists/listinfo/rails-devel > > ---------------------------------------------------------------------------- -- > All of the data generated in your IT infrastructure is seriously valuable. > Why? It contains a definitive record of application performance, security > threats, fraudulent activity, and more. Splunk takes this data and makes > sense of it. IT sense. And common sense. > http://p.sf.net/sfu/splunk-d2d-c2 > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel |
