Re: [Rails-devel] Refactored loading code

[brett l. <bre...@gm...>]

That looks good to me.

My overall goal with my refactoring is to remove the need for the
rails.game package to know about lower-level details, such as XML
parsing.

Moving the classes that need to know about how to load/save game files
outside of rails.game.* aligns very well with this goal. :-)

---Brett.



On Tue, Jul 5, 2011 at 10:11 AM, Stefan Frey <ste...@we...> wrote:
> Brett & Erik,
> some time ago I started to refactor the game loading code in one class to get
> the ListAndFixSavedFiles utility adjusted to the new comments.
>
> To avoid more incompatibilities from the started refactoring from Brett now I
> thought to adjust the code to include the new reload functionality of Erik to
> be able to commit those changes.
>
> Nearly all loading functionality has been moved to a new GameLoader class in
> rails.util package. The load function in Game, GameManager and
> ListAndFixSavedFiles now all make use of a a GameLoader object.
>
> I have also added a line to the reload error message that asks the user to
> submit the corrupt save file to the Rails user list for bug tracking. If you
> think that is not a good idea, simply remove that text from
> LocalisedProperties.
>
> Stefan
>