Re: [Rails-devel] Train management & dual trains

[Erik V. <eri...@xs...>]

> -----Oorspronkelijk bericht-----
> Van: Stefan Frey [mailto:ste...@we...]
> Verzonden: woensdag 22 juni 2011 7:17
> Aan: Development list for Rails: an 18xx game
> Onderwerp: Re: [Rails-devel] Train management & dual trains
> 
> Erik:
> of the official test suite no test goes through currently, as there has
been a
> change of the game report regarding the usage of blank lines at the begin
of
> the StartRound. Was there any specific reason to do that?

I can't remember any such change, so I can't give a specific reason, but
it's well possible that I have done that at some point. 
However, if our test cases are dependent on such details, I'm not very happy
about that. 
Improvements must remain possible. Very recently I added a report line about
President's cash contributed in  emergency train buying - this was
completely unreported so far.

I suspect that by now many old test cases will appear to be out of date for
other reasons too.  Almost all of my 18EU cases are invalid and must be
edited because one redundant Skip action had been removed at some point.  I
suppose we should revisit that whole test set. That's a separate subproject
in its own right...

I attach two test cases that I have used intensively to test the train
management changes against. These two cases cover a lot of ground.
Unfortunately, the 18EU map is wrong because it still originates from the
time before I rotated tile #4, so all these tiles are shown oriented
wrongly. Again, this applies to most of my 18EU test cases. I suppose I will
have to write a special conversion program to fix that...

> There is one (non-official) test however, that already stops with a
null-point
> exception on buying a train. Save file is attached.

That's caused by a bug in the 1830 Pere Marquette configuration. The 6-train
releases a 7-train, which is not defined for that variant. This bug must
have crept in while recently adding many other variants. I don't have the PM
rules, but from your original commit I conclude, that PM has no 7-train, so
I have fixed it accordingly.  I have also added checks to catch such misfits
during XML parsing.

Erik.