Re: [Rails-devel] Train management & dual trains

[Stefan F. <ste...@we...>]

Erik:
of the official test suite no test goes through currently, as there has been a 
change of the game report regarding the usage of blank lines at the begin of 
the StartRound. Was there any specific reason to do that? 

There is one (non-official) test however, that already stops with a null-point 
exception on buying a train. Save file is attached.

Stefan


On Wednesday, June 22, 2011 12:18:51 am Erik Vos wrote:
> I have done most of the train configuration and management changes that
> were necessary to allow dual trains, as exist in 18VA, 18Scan etc.
> It has amounted to a major overhaul of the train-related classes.
> 
> On the configuration side, the <Train> tag has been replaced by
> <TrainType>, and <Train> is now used only to define the two train types of
> a dual train certificate.
> For instance, the 18Scan 2/1+1 train is defined with
> 	<TrainType name="2/1+1" quantity="6">
> 		<Train name="2" majorStops="2" cost="100"/>
>             		<Train name="1+1" majorStops="1" minorStops="1"
> cost="80"/>
> 	</TrainType>
> 
> The single trains of all existing games are now defined like
> 	<TrainType name="2" majorStops="2" cost="80" quantity="6"/>
> In this case, the <Train> part is implicit.
> 
> The related class names are different from the tag names: <TrainType>
> relates to a new class TrainCertificateType, whereas <Train> still relates
> to class TrainType.
> Where applicable, attributes defined under <TrainType> propagate to
> <Train>, and those defined under <Defaults> propagate to both.
> The TrainTypeI interface has been discontinued.
> 
> Train objects refer to individual train *certificates*, and contain a new
> attribute actualTrainType to refer to the current TrainType. In case of
> single trains, the value is fixed, but for dual trains the initial value is
> null, and is assigned on buying whichever train type.
> The TrainI interface still exists.
> 
> I have tested with old saved files that contain examples of most special
> train actions, such as emergency buying, D-train exchange, excess train
> discarding, infinite trains and 18AL named trains. It all seems to work
> fine, but I encourage those that can work with the current code base to
> test with all your favourite saved files.
> 
> Train buying in 18Scan also works as far as this game presently can be
> played.  The two aspects of a dual train are shown as separate buy options,
> each at the correct price.
> 
> Revenue calculation also still seems to work, but I haven't really checked
> the numbers.
> 
> Erik
> 
> 
> ---------------------------------------------------------------------------
> --- EditLive Enterprise is the world's most technically advanced content
> authoring tool. Experience the power of Track Changes, Inline Image
> Editing and ensure content is compliant with Accessibility Checking.
> http://p.sf.net/sfu/ephox-dev2dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel