From: Erik V. <eri...@xs...> - 2011-03-31 10:16:31
|
Brett, Can you sort this out? You have introduced SVG and Batik. SVGOffscreenLoader was also yours, I think - can it really be removed? Personally, I don't want to spend time fixing things that ain't broke, but if Adam likes to do such work, it's fine with me. It appears to be true that we only need batik.jar. In the past I had found that I needed almost all batik jars in the classpath to prevent NoClassDefFoundErrors when running the current Rails version from the command line. Only now I discover that I had overlooked the main lib batik.jar! So that was entirely my mistake. Erik. Van: Adam Badura [mailto:ab...@o2...] Verzonden: donderdag 31 maart 2011 1:06 Aan: rai...@li... Onderwerp: [Rails-devel] Batik 1.7 In the attachment you will find transition from Batik 1.6 to Batik 1.7 along with some added SVN ignores for generated files. I have discovered that only one Batik JAR file is needed to run so I have skipped adding all the others (and also I'm not sure whether those in Batik's /lib sub-directory should ever be added anyway) however entire library is added so if they are needed later they can be added with ease. Also I had to remove one test class as it no longer compiled. It seems no JAR from the new release contains that class. Kind of odd but the class didn't seem needed anyway so I didn't give much attention to the issue. Finally for Batik and log4j JARs I have added JavaDoc web link. Having a local one seems easier but that would require either adding the JavaDoc to SVN or requiring all to have it at specified path and neither seemed justified. Also anyone willing to use a different path can easily reset it (and just remember not to commit that change). However web link seems like a good default. I haven't added links to the other libraries as JUnit is very old and JGraph is used only in one file so I skipped investigating the issue. I don't know what layout of libraries is what Java/Eclipse projects should do as I'm a noob in both. So I did it the same way it was before. Why should we upgrade? Since it is easier to upgrade in small steps then in one large step. Also it is easier for newcomers to find their way if we use latest libraries rather then old and no longer supported ones. Adam Badura |