Re: [Rails-devel] B&O PC Sale

[Erik V. <eri...@xs...>]

Bill,

Some answers below.


> -----Oorspronkelijk bericht-----
> Van: Bill Rosgen [mailto:ro...@gm...]
> Verzonden: maandag 28 maart 2011 11:14
> Aan: Development list for Rails: an 18xx game
> Onderwerp: Re: [Rails-devel] B&O PC Sale
> 
> Erik,
> 
> I'll have an attempt at implementing this.
> 
> I plan to add support for attribues to a new 'Tradeable' tag for:
> 
> toCompany
> toPlayer
> lowerPrice
> upperPrice
> lowerPriceFactor
> upperPriceFactor
> 
> The idea is to then add attributes to the PrivateCompany class to store
the
> lower and upper prices (or to compute them from the upperPriceFactor and
> lowerPriceFactor).
> 
> The question is: should I also leave these parameters in the Public
> <CompanyType>?  

No, I think this should be a complete replacement. Once you have modified
the code that finds the prices to get these from the private rather than the
public company, the old code is redundant and can be removed at some point
(but I suppose that's not urgent).

> Are there any games where different public companies
> can buy privates for different ranges of values?  I don't want to break
one set
> of games to implement another.

I don't think so, but if that would be the case, I believe we could still
catch that with our new XML. Of course, all currently implemented games must
be checked (and later converted).
 
> Also, if I make these changes, I'll also go through the XML and move the
> PriceFactor attributes to the Private <CompanyType>.  Is this going to
break
> savegame compatibility or is it otherwise a bad idea?

It shouldn't break anything as long as you don't touch the BuyPrivate class,
and I don't see any need to do that. So, yes, the old spec should ultimately
be removed (but leaving it in for a while shouldn't do any harm).

Erik