[Rails-devel] 1856 Issue

[Phil D. <de...@gm...>]

Hey all,

Discovered a 'bug' (ish) in 1856 whilst playing a game recently.
Currently rails checks to see whether the CGR is running a borrowed
train and if it is then rails forces the CGR to withhold.  The
situation that occurred in this game was that the CGR was able to run
a 4T inherited from it's merger corporations, I believe from the rules
that it must withhold revenues from a 4T until it can buy a permanent
train (I'm FAR from an expert on '56 though so if someone could
clarify that would be nice).

Admittedly this is one of those areas where the players should know
the rules but it's nice to enforce these anyway, I believe the
attached patch should fix the issue (simply changing the 'check for a
borrowed train' into a 'check if CGR has a permanent train') but would
appreciate someone more skilled just double checking the impact!

There was a further issue in that I think it was allowed to buy a 4T
from another corp, something it should not be allowed to do, but I
haven't looked into that in detail yet

Phil