Re: [Rails-devel] Corrections to Loading Game from Command Line

[Adam B. <ab...@o2...>]

    The imports are result of mishandling Eclipse. I am not used to it yet (and on the search how to switch short-cuts to Windows-style...) Sorry for that.
    I personaly do cosmetic changes if they make code styl consistent but its your call.

    Now I was thinking of a redesign of initial window. So that the application lists recently opened games for example. What do you think of it?

    Adam Badura

From: Erik Vos 
Sent: Saturday, January 22, 2011 4:36 PM
To: 'Development list for Rails: an 18xx game' 
Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line

Hi Adam,

 

Thanks for your fix. I haved applied it, except:

- the removed space in GameSetupWindow: cosmetic only.

- the qualifier in java.lang.String, which is completely redundant (I have left in your two other qualifiers, though, which at least save an import.  But we normally don’t use any qualifiers).

- the unused import of InvocationTargetException.

 

For now sending patches is the way to go.  Once you have gained a reputation of sending good patches, you will get commit access.

 

Erik.

 

Van: Adam Badura [mailto:ab...@o2...] 
Verzonden: zaterdag 22 januari 2011 2:07
Aan: rai...@li...
Onderwerp: [Rails-devel] Corrections to Loading Game from Command Line

 

    The attachement contains an SVN Patch (done on trunk/18xx) correcting two errors associated with loading game from command line argument passed to the application:

 

1) After such load File | Save command (and possibly others as well) crushed with NullPointerException due to log4j NDC not containing game key. This was caused by NDC being initialized in main thread during application startup rather then in AWT-EventsQueue thread as it happend during normal application opening and loading game through Load Game button.

 

2) A save path is associated with the game just as if the game was loaded using Load Game button.

 

 

    Do you accept those corrections? Should I commit them? What do I require to commit them? (On SourceForge my user name is "adambadura” just in case...)

 

    Adam Badura



--------------------------------------------------------------------------------
------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d 


--------------------------------------------------------------------------------
_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel