Re: [Rails-devel] More changes

[Stefan F. <ste...@we...>]

Erik:
I think I forgot to highlight some time ago my approach to skip actions, which 
are the only available. I implemented that for the startRound auctions.

I have added a step in the GameManager process method:

        // only pass available => execute automatically
        if (!isGameOver() && possibleActions.containsOnlyPass()) {
            result = process(possibleActions.getList().get(0));
        }

I check if there is only only a pass action available, if so the pass action 
gets executed automatically. The advantage is that this keeps the legacy files 
100% compatible with the new one and I do not have to check anytime creating 
actions if there is only a pass and then remove that action.

At that time I considered adding that for the Done action, but I feared to 
many side effects. There are two possible extensions: Maybe there could be two 
types of Done actions (required/possible to skip) and/or a configuration 
option to automatically skip done actions or not (It might be surprising for 
newbies if the done is automatically done). 

Stefan


On Wednesday, October 13, 2010 09:21:00 pm Erik Vos wrote:
> 4. During Stock rounds, a player's Autopass will be reset each time that a
> share or certificate limit gets exceeded as a result of some action. I have
> only tested this for the case of a presidency change, but it should work in
> all cases.
> 
> 5. In Operating rounds of games where companies can own their own shares,
> the Treasury share trading step will be skipped if nothing can be traded.
> In such cases, old saved files will have a mandatory 'Done' action. For
> backwards compatibility, this 'Done' action will be catched and skipped in
> such a case. I have tested the latter in a progressed 18EU game - I hope
> it will work in all cases.
> 
> Erik.
> 
> 
> -----Original Message-----
> From: Erik Vos [mailto:eri...@xs...]
> Sent: Tuesday 12 October 2010 21:02
> To: 'Development list for Rails: an 18xx game'
> Subject: More changes
> 
> A few more changes:
> 
> 1. Added reserved hexes facility, and applied to 18EU and 1825 maps. All
> this facility does is displaying the reserved-for company name in square
> brackets on the reserved hex (as long as no tiles are laid). Tile lays are
> not actually prevented.
> 2. Removed the "no train - no income" popup that annoys some people.
> 3. Allow >60% share ownership in certain cases, for the current Stock Round
> only. Applied to 18EU mergers.
> 
> Bug #3065007 I cannot reproduce:
> 
> "* If I start a company (purchase the president's share) and then Undo the
> act of forming it, the status window continues to show the company with the
> share price I set.
> 
> Reported by John David Galt"
> 
> In all cases I have tried, undoing the company start erases the par price.
> Maybe Stefan has fixed this one in the meantime?
> 
> Erik.
> 
> -----Original Message-----
> From: Erik Vos [mailto:eri...@xs...]
> Sent: Monday 11 October 2010 19:44
> To: 'Development list for Rails: an 18xx game'
> Subject: [Rails-devel] Dynamic company order and other fixes
> 
> I have finally managed to add a missing feature that affects all games
> implemented so far (except 1825): the operating company order is now
> dynamic. After each company turn the operating order is recalculated. The
> OR panel will be recreated if the order has changed.
> 
> I am also gradually fixing and implementing a number of outstanding bugs
> and minor requests, many of which come from John David Galt's long list.
> 
> Done so far:
> 
> - If a company has no train, "No train" is reported below the map instead
> of "Withhold".
> - Show grayed out "Buy Train" button in the train buying step if the
> company has no money, or cannot buy a train for any other reason.
> - Fix treasury selling tooltip (which said "buy" instead of "sell").
> 
> Erik.
> 
> 
> ---------------------------------------------------------------------------
> - --
> Beautiful is writing same markup. Internet Explorer 9 supports
> standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
> Spend less time writing and  rewriting code and more time creating great
> experiences on the web. Be a part of the beta today.
> http://p.sf.net/sfu/beautyoftheweb
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
> 
> 
> ---------------------------------------------------------------------------
> --- Beautiful is writing same markup. Internet Explorer 9 supports
> standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
> Spend less time writing and  rewriting code and more time creating great
> experiences on the web. Be a part of the beta today.
> http://p.sf.net/sfu/beautyoftheweb
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel