Re: [Rails-devel] 1825 patch

[Phil D. <de...@gm...>]

See attached patch.  I've done what Stefan suggested below and changed
to an IntegerState variable for the formationOrderIndex, as well as
moving it into the specific game class.  There are potentially other
games out there where this matters but I think it's niche enough to be
in the game specific files.

This also includes the start of the StockRound_1825 where I've started
thinking about receivership.  Doesn't really do much as of yet but
it's a start.

Phil

On 17 September 2010 22:57, Stefan Frey <ste...@we...> wrote:
> I have not created a test case for that, but I would guess that you should
> change the formationOrderIndex from an Integer variable to an IntegerState
> variable, as otherwise it is likely that the mechanism will fail with
> undo-actions.
>
> And I would prefer if everything related to the formationOrderIndex is kept in
> the subclass PublicCompany_1825, as it is only used by those.
> I am usually confused by variables in a base class, which are only used in
> subclass context.
>