Re: [Rails-devel] 1825 patch

[brett l. <bre...@gm...>]

Patch applied.  Thanks!

---Brett.



On Wed, Sep 15, 2010 at 8:12 AM, Phil Davies <de...@gm...> wrote:
> Could someone review and (hopefully, if it's not too broken) apply
> this patch for some updates to the 1825 implementation.
>
> There is only one shared component (IE: not in the _1825 game specific
> folder and not in the 1825 data folder) that I've hit with these
> changes and that's the PublicCompany class and it's interface
> PublicCompanyI.  The change I've made here is to add a
> formationOrderIndex to the PublicCompany interface with the attendant
> getters and setters.  The reason for doing this is that in 1825
> companies always operate in descending par value order.  When two
> companies share the same par value, they always operate in the order
> they were formed.  This value is a simple incrementing integer value
> that is a 0 for the first company at a given par, then a 1 for the
> next and so on.  This seemed the easiest way to control operating
> order for the OR's
>
> Everything else is 1825 specific code so shouldn't affect any existing
> games, but I'd certainly be keen on any feedback as to better/worse
> ways of doing what I've done so far.
>
> With this patch, 1825 becomes 'somewhat' playable.  The key issues
> that would prevent a normal game finishing:
>
> Tile placement: You are allowed to place track running off the board,
> just not running into the sea or the blank side of a brown (grey in
> rails) hex.  Currently the rails map implementation has no way of
> distinguishing between 'legal' off board and 'nonlegal' offboard track
> play.  I think this can be got round using map correction as long as
> routeawareness and revenue calculation is turned off (the bleed from
> the network going outside of the map seems to confuse it if you map
> correct and point a tile outside)
>
> Receivership and the ability to sell the presidents share to the pool
> are not implemented, this is probably the 'big thing' to get 1825 to a
> fully playable state, I've never played a game of the tabletop version
> where someone didn't dump some company into receivership so without
> that the rails implementation becomes fairly pedestrian.
>
> Route awareness and revenue calculation: Have a variety of issues.
> I'm reasonably confident I can fix these with the framework Stefan has
> put together, I just haven't got round to looking at what needs doing
> yet, so for the moment these two settings default to off.
>
> Phil
>
> ------------------------------------------------------------------------------
> Start uncovering the many advantages of virtual appliances
> and start using them to simplify application deployment and
> accelerate your shift to cloud computing.
> http://p.sf.net/sfu/novell-sfdev2dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>