[Rails-devel] Forced Selling and dumping companies

[Stefan F. <ste...@we...>]

To close the missing implementation detail I rewrote the forced selling code:

It now protects against selling the presidency of the operating company and 
adds an option in game.xml to protect against selling of the presidency of any 
other company the player owns. 

The option is a child of the EndOfGame tag :
<ForcedSelling CompanyDump="no"/>
and is set for 1889. 

Questions for those who know better/more:

- I assume that from the current list of games 1889 is the only that disallows 
selling any company presidency during forced sellling.

- Anyone interested in a GameOption to allow playing 1889 forced selling 
according to the 1830 rules.

- Forced selling also occurs on other occasions than train buying in Rails: 
1856 has several cases related to loans and interest that can trigger forced 
selling. I assume that here another company can be dumped.

- The case of dumping of a company which is the source of the train bought is 
not covered by the code specifically. I do not have a test case, but I suspect 
that company dump is possible in that case. This is a disputed case and I 
support the case that this is not possible (at least without consent of the 
new president), but if my guess is correct, the current strategy space allows 
all playing all variants.

Stefan