Re: [Rails-devel] 1856 bugs in Rails 1.3 -- undo during CGR formation hangs game

[John D. G. <jd...@di...>]

Stefan Frey wrote:
> Some comments and details of the changes below.

> Aliza Panitz wrote:
>> The attached savefile is from a test game with 3 bugs, probably all
>> related to undo actions:
>>
>> (1)  When I undo a tile lay and do something else, the route is not
>> recalculated.  If I don't pay attention and calculate manually, I get
>> the run from the previous OR.

> I could not recreate this behavior exactly, but I found something similar:
> If a company has two base tokens, one with a valid route and another without a 
> valid route, the revenue calculation did

I assume you intended to write "not"...

> return a result. This is the case for 
> the CPR with a lone token in Kitchener. 
> 
> This potentially also explains the complains of John David Galt on the revenue 
> calculation not working in his test of 1835 for BY: I do not have his save 
> file, but I guess that he tokened in Nuernberg and created a similar scenario 
> there. 

BY tokened in Furth and did all subsequent building from there.  Munich had
a token and a tile (since I wasn't allowed to build out of Furth until the
second OR) but not a run.

> Quote from his mail from 06/13/10:
>> "The route calculation logic seems correct when it gives an answer at all.
>> But in most turns it did not even guess at a revenue number for By."