[Rails-devel] Two bug fixes - questions to Erik

[Stefan F. <ste...@we...>]

Erik:
two quick fixes of reported bugs and a few comments/questions related to this:

3010534: 1856 1/2 share from limit can't buy 5% share of CGR
- The reason was that the call to the certification limit test did not 
consider the certificate count (1/2 here), assuming that each certificate 
counts full.

- From the code it seems that defining certificate types might help. Then it 
would be easier to group the certificates available in the pool or the 
player's portfolios. Other games might even have more variation. 

- The Buy action (still) do not store the certificate ids, if more than one 
certificate is sold. The sell action does not store the ids at all. The same 
is true for the Exchange for Share action. This poses the risk of reload 
errors especially after undos.

3025465: 1856. THB token spot blocked inappropriately 
- Here the case of a non-blocking home base on OO-Tiles was not accounted for. 
Fixed that now by changing the home city to null as long as the home city is 
not selected. Adjusted the paint method in GUIHex to find a free slot to 
paint the home company name on.

- I always wonder, if the token methods and the token variables in city are 
restricted to BaseTokens only or if they can hold any type of Tokens (as the 
TokenI signature suggests). If the latter is the case some methods might not 
work as intended, for example hasTokenSlotsLeft().
Sometimes it seems that the common interface TokenI creates more confusion 
than it saves code, as most of the time Base and BonusTokens are handled in 
separate methods anyhow. 

- Going forward thinking about 1870 which has DestinationTokens, which behave 
in some respect like BaseTokens and in other like BonusTokens, things do not 
get easier in the near future. A general token class, which allows to 
configure the behavior of tokens and define TokenTypes might be an 
alternative, but requires lot of refactoring. But then the TokenI interface 
is helpful for a start with.

Stefan

Curiuos, who wins the worldcup tonight ;-) Good luck for the Dutch team.