Re: [Rails-devel] Bug fix for train exchange

[Erik V. <eri...@xs...>]

Question to Erik:

There was even a TODO comment inside the BuyTrain action:
               trainsForExchangeUniqueIds[i] = trains.get(i).getName();
                // TODO: Must be replaced by unique Ids

It was not the important line (that is the one which defines the 
exchangedTrainUniqueId variable).
But still any reason why you have used getName() at the time of 
implementation?


[EV] Don't remember that. Obvious possibilities:

1. It might have enabled me to reuse old saved files.
2. For some reason I might have thought this change required more thought -
and then forgot about it.
3. Overlooked this case when introducing uniqueIds.

Anyway, fine that you have spotted and fixed this one. 
By now I'd say that we should not worry too much about old saved files any
more, in particular with 1835.

Erik.