Re: [Rails-devel] 1835 Prussian does not pay out (3014303)

[Erik V. <eri...@xs...>]

See below. 

-----Original Message-----
From: Phil Davies [mailto:de...@gm...] 
Sent: Thursday 10 June 2010 13:44
To: Development list for Rails: an 18xx game
Subject: Re: [Rails-devel] 1835 Prussian does not pay out (3014303)

Thought about this further...I assume this is here for the specific OR
for when the 5 gets bought?  In that specific round, it's possible
(likely) that the Prussian will run after certs have been forceably
merged that have already earned income.  I'm guessing this code is
there to prevent a player earning from a cert twice in that specific
round, since it's the only round where the Prussian could run and
players have already earned from certs.

[EV] That's indeed the rule: the PR can run (except when M2 has run), but
players who have already earned income from merged preprussians don't get
their income. This the official interpretation from the author, see Q5.1 in
http://web.archive.org/web/20041024222224/http://www.geocities.com/TimesSqua
re/Arena/5276/depot/1835f.htm#5.0

I can see what's wrong, in our game we have a player who has potential
Prussian certs in the form of minors 1,4 and 5.  But he currently
doesn't have any shares of the Prussian, so at line 128 in
OperatingRound_1835 it is trying to get the shares that this player
has in Pr and throwing a nullpointer exception.

[EV] Ah, that's a bug. Now fixed; but I don't have a good test case, can you
test it?

Erik.