Re: [Rails-devel] 1835 Prussian does not pay out (3014303)

[Phil D. <de...@gm...>]

Thought about this further...I assume this is here for the specific OR
for when the 5 gets bought?  In that specific round, it's possible
(likely) that the Prussian will run after certs have been forceably
merged that have already earned income.  I'm guessing this code is
there to prevent a player earning from a cert twice in that specific
round, since it's the only round where the Prussian could run and
players have already earned from certs.

I can see what's wrong, in our game we have a player who has potential
Prussian certs in the form of minors 1,4 and 5.  But he currently
doesn't have any shares of the Prussian, so at line 128 in
OperatingRound_1835 it is trying to get the shares that this player
has in Pr and throwing a nullpointer exception.

On 10 June 2010 12:20, Phil Davies <de...@gm...> wrote:
> Just raised the above issue and having a peek to see if I could see
> what was wrong.
>
> It seems that when the Prussian pays out, rails does a check to see if
> any players shouldn't get income from the payout, but I don't
> understand why it is doing that check?  If the Prussian is formed such
> that someone has already earned money from the minor or private that
> is folded into the Prussian, then the Prussian shouldn't run on that
> OR.  If it runs in the next OR...the minors/privates will have been
> folded in at the beginning of that OR when they would not have had a
> chance to earn their owners revenue prior to the Prussian operating.
>
> Am I missing a nuance in the Prussian rules?
>
> Phil
>