Re: [Rails-devel] Implementation details for revenue calculation

[Phil D. <de...@gm...>]

Stefan,

I've managed to run an 1856 game through with revenue calc once  
already with very little problems, though this was before you added  
token support.

It was certainly able to handle some 1200+ revenue Diesel runs with  
minimal impact on processing speed and I am certainly glad I didn't  
have to count those manually.

Phil

On 25 May 2010, at 08:59, Stefan Frey <ste...@we...> wrote:

> Phil:
> in my area (routing and revenue calculation) 1856 is the game I  
> hardly tested.
> If I am not wrong, it has no unique features, thus everything should  
> work
> fine, but that is a "should", thus tests would be very welcome there.
> 1835 should work ok in that respect.
> Stefan
>
>
> On Tuesday 25 May 2010 09:02:30 Phil Davies wrote:
>> I'll probably be starting another game from source this week to test
>> the impact on other games, is '35 at the stage where it would be
>> worthwhile getting some testing feedback?  I was thinking of trying
>> that out on my regulars.
>>
>> On 24 May 2010 12:48, Erik Vos <eri...@xs...> wrote:
>>> 18EU Bankruptcy now seems to work correctly, and is open for  
>>> testing for
>>> whoever is interested in this feature and can compile from the  
>>> sources.
>>> In particular, more testing is needed for side effects on other  
>>> games, as
>>> the processes of starting and closing companies has changed  
>>> somewhat. The
>>> visibility of companies in GameStatus and ORPanel was the last main
>>> issue.
>>>
>>> Undo is getting better, but doesn't yet seem work completely.
>>>
>>> More later this week.
>>>
>>> Erik.
>>>
>>> -----Original Message-----
>>> From: Stefan Frey [mailto:ste...@we...]
>>> Sent: Monday 24 May 2010 10:00
>>> To: Development list for Rails: an 18xx game
>>> Subject: Re: [Rails-devel] Implementation details for revenue  
>>> calculation
>>>
>>> Erik & Brett,
>>> currently quite occupied with other tasks I am only adding small  
>>> bits in
>>> an incremental way. I think 1.3.0 is appropriate with a new game
>>> supported and the first step to revenue and route support.
>>>
>>> I have added the support (or better removal) of the Birmingham tile
>>> before phase 4 by defining an according NetworkGraphModifier  
>>> interface,
>>> which allows
>>> to adjust the network graph immediately after creation. Changes  
>>> defined
>>> by this interface also effect the highlighting for tile and token  
>>> lays.
>>>
>>> This implies that all titles should be supported, but I am sure  
>>> there is
>>> still
>>> something is missing, especially for those games which I only know  
>>> from
>>> the rulebook.
>>>
>>> The fix of the 18EU bankruptcy should allow to close the bug  
>>> 2954661.
>>> Game End undos are already possible (I fixed that in 1.2).
>>> Do you think it will be possible to provide an undo possibility  
>>> for the
>>> bankruptcy in 18EU as well?
>>>
>>> Stefan
>>>
>>> On Friday 21 May 2010 22:10:41 Erik Vos wrote:
>>>> Next weekend sounds good. In view of all the great stuff added by
>>>> Stefan,
>>>
>>> a
>>>
>>>> minor release (1.3.0) might be appropriate?
>>>>
>>>> By now the bugs list is pretty empty; in the past few weeks I  
>>>> have fixed
>>>> quite a lot.
>>>>
>>>> I'm working on the 18EU bankruptcy rules, which were missing. I  
>>>> hope to
>>>
>>> get
>>>
>>>> that done this weekend, but I'm currently much distracted by other
>>>> activities, so progress is slow. Right now, 18EU hangs in case of a
>>>> bankruptcy, but I would't consider that a show-stopper; to my  
>>>> knowledge
>>>> bankruptcies are rare in 18EU.
>>>>
>>>> I have added comments to the 1835 description on a few remaining  
>>>> issues,
>>>> with workarounds, but otherwise I think it's about done. I have  
>>>> marked
>>>
>>> 1835
>>>
>>>> "almost playable".
>>>>
>>>> Erik.
>>>>
>>>> -----Original Message-----
>>>> From: brett lentz [mailto:bre...@gm...]
>>>> Sent: Friday 21 May 2010 18:55
>>>> To: Development list for Rails: an 18xx game
>>>> Subject: Re: [Rails-devel] Implementation details for revenue
>>>> calculation
>>>>
>>>> On Fri, May 21, 2010 at 9:18 AM, Stefan Frey <ste...@we...>  
>>>> wrote:
>>>>> Again some more update:
>>>>>
>>>>> Full support for 18AL and 18EU is in, 1851 has only Birmingham
>>>>> missing. More details see below.
>>>>>
>>>>> As Brett and Erik keep quiet about their preference for a release
>>>>> soon,
>>>
>>> I
>>>
>>>> kept
>>>>
>>>>> adding functionality.
>>>>
>>>> Excellent work.
>>>>
>>>> As for when to do a new release, a lot of it is down to how stable
>>>> your changes are.  It sounds like we may be nearing a point where  
>>>> we
>>>> are ready for a new release.
>>>>
>>>> How does next weekend sound?
>>>>
>>>> ---Brett.
>>>
>>> --- 
>>> --- 
>>> -------------------------------------------------------------------
>>> --
>>>
>>>> - --
>>>>
>>>> _______________________________________________
>>>> Rails-devel mailing list
>>>> Rai...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>>
>>> --- 
>>> --- 
>>> -------------------------------------------------------------------
>>> --
>>>
>>>> ---
>>>>
>>>> _______________________________________________
>>>> Rails-devel mailing list
>>>> Rai...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>>
>>> --- 
>>> --- 
>>> -------------------------------------------------------------------
>>> --- --
>>>
>>> _______________________________________________
>>> Rails-devel mailing list
>>> Rai...@li...
>>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>>
>>>
>>> --- 
>>> --- 
>>> -------------------------------------------------------------------
>>> -----
>>>
>>> _______________________________________________
>>> Rails-devel mailing list
>>> Rai...@li...
>>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>
>> --- 
>> --- 
>> ---------------------------------------------------------------------
>> ---
>>
>> _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
>
> --- 
> --- 
> --- 
> ---------------------------------------------------------------------
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel