Re: [Rails-devel] Implementation details for revenue calculation

[Stefan F. <ste...@we...>]

Again some more update:

Full support for 18AL and 18EU is in, 1851 has only Birmingham missing. 
More details see below.

As Brett and Erik keep quiet about their preference for a release soon, I kept 
adding functionality.
Fortunately this proved to be very easy, as most elements are well prepared. 
I was especially surprised by the excellent support of named trains in 18AL, 
as  without revenue calculation it served no real purpose.
Thus it is not surprising that there are still some minor hassles, which will 
be easy to iron out.

Known open issues:
-> Invisible Birmingham tile
-> Named trains are not assigned after reload
-> 4D in 18AL do not score double (they are not correctly initialized)
-> Graph optimization after off-board area token is not correct

Complete summary of revenue specifics:

Independent tests of those is appreciated.
Map Correction allows to create scenarios easily.
Under NetworkInfo one can run any type of trains in any game, simply use 
standard train type names (like D, 4+4, 10, 5E, 4D).

1830:
Multi-Hex off-board locations

1889:
Diesel Revenue Bonus at off-board locations

1835:
Berlin: No visit of multiple stations (yellow tile only)
Hamburg: Elbe malus
Plus Trains

18EU:
Offboard-Bonus: Dependent on number of tokens visited
Hamburg: Termination vs. Non-Termination
Paris, Berlin, Vienna: No visit of multiple stations
Pullman: Bonus for most valuable city
Trains do not count Towns

18Kaas:
Ruhr: Bonus for other stations/cities

1851
Offboard-2-Offboard: 10 bonus for each stop
Invisible Birmingham: still open

1856
Bonus tokens

18AL
Bonus tokens
Named Trains
Nashville, Mobile: Off-map destinations with token slot
Trains do not count Towns
4D trains

Conversion from Rails to Network attributes:

- If a Rails hex has a value attribute, that value takes preference for all 
stations on that hex, thus the value attribute of the stations of the tile 
laid is irrelevant (no need for -1 or 0).

- Run-Through ("Not a sink") rule listed by priority
1) Off-Map city: No one runs through (even with own token)
2) Slots=0: All run through
3) Nb Tokens = Slots: Only run through with own token
4) Nb Tokens < Slots: All run through
In addition to rule 1: An own token in an off-map city allows to run from.
 
- Location names to identify vertex sets:
The location name is the combination of the city attribute of the hex and city 
tile. If any of them are undefined or equal to "", no location is defined.
Exception are off-map cities, for which only the hex attribute is considered.

Stefan