Re: [Rails-devel] revenue library

[Stefan F. (web.de) <ste...@we...>]

Some more updates to the revenue calculator:

As a result 1835 is now fully supported.

Open issues:
-> Berlin tile still has to be added to the hand-made tiles (city names to
block double runs to yellow Berlin).

-> Hamburg tile has to be layed without rotation, otherwise the Elbe malus
is not applied correctly.

-> I assume that Elsac/Lothringen is a single multi-hex off-board area, thus
cannot be included both into a single run (It is not 100% clear from the 
different rules).

General Changes are:
-> Complex bonuses (multi-vertex) are possible (as in HH).
-> All vertices with special conditions are protected throughout the graph
optimization.
-> The message box shows now the individual value of each train and adds
line breaks for long runs. Complex Bonuses are shown at the end of the run, 
simple bonuses as a "+ xx" value  for the vertex.

I do not know, what the general opinion is: I would prefer not too wait too 
long for the next release to get more feedback. Currently we have 1830, 1835 
and 1889 with complete support of revenue calculation. All games (except 1851 
with the invisible Birmingham) should have the basic route awareness working.

All others are more complex and require the RevenueModifiers, which I would 
prefer to keep back until the next release. It is possible to add some of the 
games at minor releases.

My proposal is:
1) Define a gameOption for RevenueCalculation with two settings for now: 
{None, Suggest} for 1830, 1835, 1889
2) Define a gameOption for RouteAwareness with two settings for now:
{None, (Hex)Highlight} for all games, except 1851

An open question is whether the default should be none or one of the active 
ones. If the active selection is chosen, I would suggest, that we add another 
default for those games saved by previous version ("undefined default") and 
set those to none. Otherwise people might complain that they get a feature, 
that they did not want at the start of their game.

And another question: Anyone suggest better colors (RGB values) for the 
routing paths. I do not know, if I have time to figure out, how I make those 
configurable from the properties file.

Stefan