Re: [Rails-devel] Closing companies

[Erik V. <eri...@xs...>]

It turns out, that the saved BuyTrain action did not specify the exchanged
train name. The only possible cause I could find is that the Cancel button
had been pressed on the question which train should be exchanged (in this
case: the 4 or the 5-train). Hitting Cancel was not adequately catched in
the UI code, and the missing exchanged train was not catched in the server
validation code either.

I have tightened both pieces of code (testing with an 1830 saved file) and
it now seems to work OK. The sad result is, that your saved file is now
invalid and will no longer load...

Erik.


-----Original Message-----
From: Phil Davies [mailto:de...@gm...] 
Sent: Wednesday 12 May 2010 11:06
To: Development list for Rails: an 18xx game
Subject: Re: [Rails-devel] Closing companies

Excellent, confirmed as working, although, I notice on loading up this
same save file that GW has 5 5 D in trains...that's not right, it
should have 5D with a 5 in the pool, so it looks like the issue of
exchanges for D's not working correctly from saved files is back
again.  Interestingly trying to load this save file in the list and
fix save files utility, you get a nullpointer exception when it tries
to load action 547 (which I believe is the action to exchange the 5
for the D)

Phil

On 11 May 2010 20:50, Erik Vos <eri...@xs...> wrote:
> It was a typo (first character not uppercased) in StockMarket.xml. Duh.
> Fixed now.
>
> Erik.
>
> -----Original Message-----
> From: Phil Davies [mailto:de...@gm...]
> Sent: Tuesday 11 May 2010 17:23
> To: Development list for Rails: an 18xx game
> Subject: Re: [Rails-devel] Closing companies
>
> ...and after actually reading the bug tracker instead of firing off
> random emails, I see it is logged.  Attached is a save file, just sell
> one share of BBG and you are there.
>
> Phil
>
> On 11 May 2010 16:11, Phil Davies <de...@gm...> wrote:
>> Has anyone implemented closing companies yet?  I've on the receiving
>> end of a rather brutal few turns play in 1856 and we just pushed a
>> company into the closed area of the board, yet nothing has happened.
>> I can see a <ClosesCompany/> tag on the StockMarket but is this
>> checked and acted on or is this still pending?
>>
>> Phil
>>
>
>
>
----------------------------------------------------------------------------
--
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

----------------------------------------------------------------------------
--

_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel