Re: [Rails-devel] Implementation details for revenue calculation

[Stefan F. <ste...@we...>]

Erik:
I agree that is really hard to know (predict) what all the 18xx (might) have 
defined, especially in those areas which are not that important to be covered 
by the rules comparison list. For those details everyone is restricted to the 
knowledge of the titles he plays regularly.

In some sort re-factoring is always a kind of reinventing. Hopefully to the 
better.

I fixed the issue with the ClosePrivate implementation, some leftover of the 
separation of the correction actions prevented the propagation of the action 
down to the OR class.

I will be away for a week on vacation, I hope to find a finalized 1835 after 
that ;-)

Stefan

> It's usually impossible to tell beforehand if some special case can be
> handled by a generic property, or needs special code (in a game-specific
> subclass). I usually try to find out how it can be done with minimal code.
> In this case I gladly leave it to you how to model all of this. I only got
> a (perhaps unjustified) feeling that you were reinventing some wheel. But I
> may be wrong, and in that case I have said nothing. Peace is not in danger.
>
> Erik.
>
>
> ---------------------------------------------------------------------------
>--- _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel