Re: [Rails-devel] Implementation details for revenue calculation

[Stefan F. (web.de) <ste...@we...>]

> [EV] Zero slots should be interpreted as: everybody can run through.
> I think such a rule would be generic enough, not needing additional
> attributes for *this* purpose.
>

Sure you can encode some of boolean attributes into the numerical attribute of 
slots.

Another extension allows the pattern:
slots = 0 => always run through 
slots = -1 => never run through (as standard off-map areas)

I personally favor defining more variables and prefer not encode several 
dimensions into one variable.

In your defintiion e.g. a Station is fully tokened if number of slots == 
number of tokens or number of slots equals zero.

In my definition a Station is fully tokened if (number of slots == numer of 
tokens). I would first check if the station is fully tokened and then the 
different booleans define what companies can if they have or have not an own 
token.

But in fact your are right: it is matter of preference.


> For solving the whole variety of possible off-map locations we need more
> flexibility and generality as outlined by the new attributes.
>
> [EV] Yes, but attributes of what?
> I think we basically have two dimensions: StationType and TrainType.
> The intersection (matrix) of these types needs properties that define
> the behaviour towards revenue calculation; I think we can assign
> such properties to either one.
> TrainType already exists, StationType would be a new class
> (already proposed by you), defined in some ConfigurableComponent.

Attributes of stations as outlined below. I hope that the question how tokens 
influence the running of train is not train dependent.

> B) Upgrades to green Berlin are not allowed (no valid orientation).
>
> I can provide save files if required.
>
> [EV] Yes please, for case B. I'm hitting on another bug when trying to get
> there... :-(
>

Attached. Hope you can open it, if you have changed anything already.

I have attached another one: At least on my laptop the southern part of the 
map is not shown anymore when Bay is active, as they have several special 
lays available. And no scrollbar shows up to scroll down.

Stefan