Re: [Rails-devel] Implementation details for revenue calculation

[Erik V. <eri...@xs...>]

 

-----Original Message-----
From: Stefan Frey [mailto:ste...@we...] 
Sent: Saturday 01 May 2010 20:58
To: Development list for Rails: an 18xx game
Subject: Re: [Rails-devel] Implementation details for revenue calculation

Erik:
thanks, it is moving in the right direction, but it is still not on the 
target: Having zero slots it evaluates as fully tokened, thus no one can run

through. Setting slots to one, it would allow tokening :-(

[EV] Zero slots should be interpreted as: everybody can run through.
I think such a rule would be generic enough, not needing additional
attributes for *this* purpose.

For solving the whole variety of possible off-map locations we need more 
flexibility and generality as outlined by the new attributes. 

[EV] Yes, but attributes of what?
I think we basically have two dimensions: StationType and TrainType. 
The intersection (matrix) of these types needs properties that define
the behaviour towards revenue calculation; I think we can assign 
such properties to either one. 
TrainType already exists, StationType would be a new class
(already proposed by you), defined in some ConfigurableComponent.


At tests for revenue calculation on a 1835 map I ran into the following bugs

quickly:

A) Hamburg north (base of 6) has a value of 20, instead of the correct 40.

[EV] Correct. Fixed.

B) Upgrades to green Berlin are not allowed (no valid orientation).

I can provide save files if required.

[EV] Yes please, for case B. I'm hitting on another bug when trying to get
there... :-(

Erik.