Re: [Rails-devel] Implementation details for revenue calculation

[Stefan F. <ste...@we...>]

Erik:
thanks, it is moving in the right direction, but it is still not on the 
target: Having zero slots it evaluates as fully tokened, thus no one can run 
through. Setting slots to one, it would allow tokening :-(

For solving the whole variety of possible off-map locations we need more 
flexibility and generality as outlined by the new attributes. But you are 
right, we should think that through carefully to both add enough flexibility 
and not breaking any of the old code. For the time being I will simply ignore 
the track structure in tile.xml for the off-map locations and rely on a 
separate defined graph structure, where no side-effects are possible.

In any case the new functionality can come in handy at times.

At tests for revenue calculation on a 1835 map I ran into the following bugs 
quickly:

A) Hamburg north (base of 6) has a value of 20, instead of the correct 40.
B) Upgrades to green Berlin are not allowed (no valid orientation).

I can provide save files if required.

Stefan



On Friday 30 April 2010 17:32:04 Erik Vos wrote:
> OK, I have replaced tile -939 in Tiles.xml by a handmade version.
> This applies to the generic Tiles.xml and to 1856 (Goderich) and 18EU
> (Hamburg).
> The extra element is a "City" type station, with zero slots.
> The tile is still recognizable as an off-board tile by its colour ("red").
>
> Please check if this works for you.
>
> There is now a new XML file called HandmadeTiles.xml.
> During running the XML conversion tool ConvertTilesXML,
> tile entries in this file are used; the corresponding
> tiles in TileDictionary.xml are not converted but skipped.
>
> Erik.
>
> -----Original Message-----
> From: Stefan Frey [mailto:ste...@we...]
> Sent: Thursday 29 April 2010 21:58
> To: Development list for Rails: an 18xx game
> Subject: Re: [Rails-devel] Implementation details for revenue calculation
>
> yes that helps, otherwise it would not be scored. The same is true for the
> equivalent tile in 1856.
>
> The (additional) virtual vertex takes care of the bonus condition to end
> the
>
> run at the off-board location and is thus only required for 18EU.
>
> On Wednesday 28 April 2010 21:41:08 Erik Vos wrote:
> > Would it help if I changed the tile description in Tiles.xml accordingly?
> > (i.e. as you say: "a non-tokenable station in the middle of the hex")
> >
> > Erik.
> >
> > -----Original Message-----
> > From: Stefan Frey (web.de) [mailto:ste...@we...]
> > Sent: Wednesday 28 April 2010 00:37
> > To: Development list for Rails: an 18xx game
> > Subject: [Rails-devel] Implementation details for revenue calculation
> >
> > 4) 18EU
> >
> > Hamburg: I have to admit that I do not like the Hamburg offboard tile:
> > The graphical representation does not define exactly, where the value
> > vertex is,
> >
> > as it does not contain any type of station.
> > I assume the most natural interpretation is to assume a non-tokenable
> > station
> > in the middle of the hex (similar to tile 12, only that the slot cannot
> > be filled). To work with the offboard bonuses, an additional vertex is
> > connected
> > to the station vertex, which acts as a sink (has no neighbors defined,
>
> thus
>
> > similar to a tokened out station). All of the bonus combinations for
> > Hamburg
> >
> > use that vertex to enforce the restriction that the bonus runs have to
>
> stop
>
> > in Hamburg. (D)
>
> ---------------------------------------------------------------------------
>
> >--- _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
>
> ---------------------------------------------------------------------------
>- --
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
> ---------------------------------------------------------------------------
>--- _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel