Re: [Rails-devel] Junit reports broken test cases

[Erik V. <eri...@xs...>]

Fixed two bugs in the Erie tile-laying and token-jumping case:

- the code to prevent one brown OO city to pick up both green OO
connections, had been commented out in Rails 1.0.5 for unexplained reasons.
Guess it's my error (mea culpa).

- City.relatedStation should have been a State variable but wasn't. This
occasionally caused the cities (and hence the tokens) to be swapped after an
Undo (or rather: not be unswapped by the Undo). 
I haven't seen any token-swapping cases yet that are not caused by an Undo.
Sorry, no time for thorough testing these days.

Erik.

-----Original Message-----
From: Erik Vos [mailto:eri...@xs...] 
Sent: Friday 16 April 2010 23:30
To: 'ste...@we...'; 'Development list for Rails: an 18xx game'
Subject: RE: Junit reports broken test cases

These two files reflect identical game positions, both having Erie green and
C&A brown. 
Indeed one brown OO tile lay let the Erie token jump, but perhaps even worse
is that several wrong brown tile lays are allowed.
That wasn't so in the past, so I wonder what might have broken that logic.