Re: [Rails-devel] Fwd: Problem with Rails 1.2

[brett l. <bre...@gm...>]

Should we do a 1.2.2 release for this?


---Brett.



On Fri, Mar 19, 2010 at 1:53 PM, Erik Vos <eri...@xs...> wrote:
> This problem was indeed caused by the Stefan's fix. That fix was basically
> correct, as my way to allow done in this case was a shortcut that broke the
> (unwritten) rules. But the purpose of that shortcut (enabling Done) was not
> reinstated in any other way.
>
> I have now done it in the regular way. Done will now be enabled after
> repaying loans.
>
> Erik.
>
>
> -----Original Message-----
> From: Stefan Frey [mailto:ste...@we...]
> Sent: Friday 19 March 2010 17:05
> To: rai...@li...
> Subject: Re: [Rails-devel] Fwd: Problem with Rails 1.2
>
> Erik:
> from the description alone I guess that this is caused by a bug fix of mine
> on the undo mechanism. Do you remember our discussion about the change from
> the postcondition check (which requires the use of state variables) for the
> done button to a precondition check (which avoids that).
>
> It seems that there is a case not covered in the 1856 repay loan action step
>
> yet, that does not set the doneAllowed variable. Thus it might be a good
> guess to check the preconditions there.
>
> I look forward to checking in my automated testing procedures which
> hopefully
> reduce those side-effects of refactoring.
>
> STefan
>
>
> On Friday 19 March 2010 16:10:49 brett lentz wrote:
>> ---------- Forwarded message ----------
>> From: Arne Östlund <arn...@gl...>
>> Date: Thu, Mar 18, 2010 at 11:27 PM
>> Subject: Problem with Rails 1.2
>> To: rai...@li...
>>
>>
>> Hi Brett/Erik
>>
>> We are playing an 1856 PBeM campaigne. Due to an error with Rails
>> 1.1.3 I tried to recreate our moves in Rail 1.2 to current status by
>> redo some turns. But when I repayed the Loans for LPS after an
>> withhold, one OR before the CGR formation, the game stalled. The only
>> option I got was to Undo. So we can not pass this state and continue
>> the game!
>>
>> /Arne Östlund
>
>
>
> ----------------------------------------------------------------------------
> --
> Download Intel&#174; Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
> ------------------------------------------------------------------------------
> Download Intel&#174; Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>