Re: [Rails-devel] Info

[Phil D. <de...@gm...>]

On 23 February 2010 20:23, Erik Vos <eri...@xs...> wrote:
> Gave this one a shot, in several cases I found the local getInfo() was
> just pointing straight at the toMenu() method so I've done the same
> here.  I also extended the description to include the value for the
> routes on the named trains and the full name for the destinations.
>
> [EV] Equalizing toMenu() and getInfo() can be an easy shortcut, and it
> reduces the number of LocalizedText entries (which is a Good Thing). But it
> does not work if the info gets long (3 lines in this case). And to make it
> worse, this special property now shows up *twice* in the Special menu for
> the company owning M&C (not sure why).
> In any case, toMenu() should produce a sensible and not overly long
> one-liner.

Where does the toMenu() get called? the info menu is a menu in and of
itself, so I wsn't entirely sure on the difference.  I'll certainly
clear that back to one line and in this case produce different
versions for the train naming I think.

> One thing that might be an issue is the text for SpecialTrainBuy which
> states 'Close {private} to purchase...' This would be incorrect if
> there is an 18XX game out there that had train discounts that didn't
> close the private.  I am unaware whether or not such a game exists so
> this might need further clarification if this is the case.
>
> [EV] The worst thing about this text is, that you put the side effect
> (closing the private) at the front, where the main purpose (buying a cheap
> train) should be. So I would suggest something like "Purchase.... (closing
> <private>)".

Hmm, Interesting, I think it depends whether you view closing the
private as a cost or a consequence.  In some games (not talking 18XX
here, just generic boardgames) you would often see powers listed as:

Cost: benefit

So I immediately think of things in these terms (I close the private,
that allows me to buy a train cheaply) rather than closing the private
being a consequence of choosing to buy a cheap train.  I think this
comes down to a personal choice but I can appreciate your thinking on
this.  We should be emphasising the benefit instead of the detriment
so this should get switched round.

> Also, you haven't localized "any".

Very valid point...was trying to think of a cute way of doing this and
obviously failed :p

> I'm also unaware of any other cases (which proves nothing). We can always
> refine if such a case would show up later.

> [EV] Want to try another shot?

As long as you don't mind me bothering you for feedback, I'll get a
chance to play with this during the week hopefully.

Phil