Re: [Rails-devel] Info

[Erik V. <eri...@xs...>]

Gave this one a shot, in several cases I found the local getInfo() was
just pointing straight at the toMenu() method so I've done the same
here.  I also extended the description to include the value for the
routes on the named trains and the full name for the destinations.

[EV] Equalizing toMenu() and getInfo() can be an easy shortcut, and it
reduces the number of LocalizedText entries (which is a Good Thing). But it
does not work if the info gets long (3 lines in this case). And to make it
worse, this special property now shows up *twice* in the Special menu for
the company owning M&C (not sure why).
In any case, toMenu() should produce a sensible and not overly long
one-liner. 

One thing that might be an issue is the text for SpecialTrainBuy which
states 'Close {private} to purchase...' This would be incorrect if
there is an 18XX game out there that had train discounts that didn't
close the private.  I am unaware whether or not such a game exists so
this might need further clarification if this is the case.

[EV] The worst thing about this text is, that you put the side effect
(closing the private) at the front, where the main purpose (buying a cheap
train) should be. So I would suggest something like "Purchase.... (closing
<private>)".
Also, you haven't localized "any". 
I'm also unaware of any other cases (which proves nothing). We can always
refine if such a case would show up later.

[EV] Want to try another shot?

Erik.