Re: [Rails-devel] 1856: CGR Formation stalls when keeping all trains

[Aliza P. <ali...@gm...>]

Erik:

I'm glad that my playtesting is useful!

The only earlier savefile I have from this game is quite a bit
earlier, when I saved the session to file a bug report on buying
tunnel tokens after the first 5-train was bought. That's file
1856_20091224_2344-lps-cant-buy-tunnel-token.rails attached to my bug
report from Dec. 24th.

Clearly I'm used to different play styles than you are, as the CGR
almost never drops its 4-trains in my experience. (However, I find it
quite difficult to play "fair" with my imaginary friends, so my test
games do develop a bit oddly at times.  )

I'd be glad to play forward with your fixes, but I don't have a Java
build environment on my laptop.  (I've never programmed anything in
Java, and haven't done anything but shell and Perl scripts in quite a
few years.)

 - Aliza

On Sun, Dec 27, 2009 at 10:45 AM, Erik Vos <eri...@xs...> wrote:
> You're really good at finding bugs in untested dark corners
> (i.e. special combinations of circumstances that have escaped
> everyone's attention so far... :-)
>
> This time there were two:
>
> 1. If CGR did not discard a non-permanent train when offered
> the chance to do so, the player action did not close that step,
> i.e. the program started repeatedly asking the same question.
>
> 2. If, after CGR formation, all of the remaining companies
> already have operated, the current OR must be finished and
> a new OR must be started. That is what happened, but the
> whole complex sequence of steps was incorrectly wrapped up,
> so that in fact the old OR was trying to continue with a
> company that already had been closed (in this case, the GT).
>
> I have uploaded fixes. However, your saved file still cannot
> be processed because it contains a large sequence of DiscardTrain
> actions, where only one is now expected by the fixed code.
>
> Do you still have a saved file from an earlier time?
>
> I am considering building a tool that would enable fixing
> such unprocessible save files by removing invalid *trailing*
> actions, but that may take a bit of time.
>
> Erik.
>
> -----Original Message-----
> From: Aliza Panitz [mailto:ali...@gm...]
> Sent: Friday 25 December 2009 02:18
> To: Development list for Rails: an 18xx game
> Subject: Re: [Rails-devel] 1856: CGR Formation stalls when keeping all
> trains
>
> The savefile is too big, so my message is being held for moderator approval.
>
> On Thu, Dec 24, 2009 at 5:14 PM, Aliza Panitz <ali...@gm...>
> wrote:
>> Attached is a savefile from a game where the CGR forms with a 4 and
>> two 5 trains.  Rails will not let me keep all three trains, although
>> the CGR has a train limit of 3.
>>
>> Even if I discard a train, there doesn't appear to be a "done" button
>> to let me proceed with play.
>>
>> I will also mention that having the map disappear as people are being
>> asked to decide about CGR formation is quite disconcerting, as map
>> position can be a factor in deciding whether or not to keep a
>> struggling company. (There was no way to bring it back up.)
>>
>> I saved and reloaded the game, but it still appears to be stuck.
>>
>>  - Aliza
>>
>
> ----------------------------------------------------------------------------
> --
> This SF.Net email is sponsored by the Verizon Developer Community
> Take advantage of Verizon's best-in-class app development support
> A streamlined, 14 day to market process makes app distribution fast and easy
> Join now and get one step closer to millions of Verizon customers
> http://p.sf.net/sfu/verizon-dev2dev
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
> ------------------------------------------------------------------------------
> This SF.Net email is sponsored by the Verizon Developer Community
> Take advantage of Verizon's best-in-class app development support
> A streamlined, 14 day to market process makes app distribution fast and easy
> Join now and get one step closer to millions of Verizon customers
> http://p.sf.net/sfu/verizon-dev2dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>