[Rails-devel] Changes to rc4

[Erik V. <eri...@xs...>]

I found 4 new bugs reported in Sourceforge, of which 2 only cosmetic.
I fixed three of these. For the last one, the attached save file has a
problem.

#2905363: 18EU map doesn't update when minor merger token is replaced.
Analysis: this is true in general of actions outside an OR that affect the
map.
There was a hardcoded link between such updates and other OR-activities that
prevented this so far.
Fix: Token changes (and other gamehex-affecting changes) are now reflected 
on the map outside ORs as well. I do hope this hasn't broken anything,
but some tests with late 1856 and 18EU save files were successful.

#2905482: 18EU port hexes should not be red
Comment: 18EU gives red-to-red bonuses. The port hexes should not be red to
avoid
confusion with the red cities.
Analysis: this is only cosmetic, but I understand that it's confusing.
The problem is that TileDesigner has insufficient options to render all
preprinted tiles.
Fix: I have replaced tile #-901 by tile #-800 for the 18EU ports.
This is a gray tile with a short piece of track and a village, 
and was so far only used for Rostock in 1835. 
I hope this will do; this was the only alternative I could find
in the current tile set.

(BTW Selecting a better tile set is a long-standing open issue that 
I think we will need to revisit soon).

#2906941: Extra train jettison in 18EU
Analysis: I could not reproduce this problem from the attached save file,
because of an earlier invalid move. See my comments in this item.

#2909261: 1830 M&H swap for NYC doesn't float company
Analysis: very true, unfortunately. A day 1 oversight, it seems.
Fix: flotation checking has been added.

Erik.