Re: [Rails-devel] New ClassLoader

[Erik V. <eri...@hc...>]

> I've just committed some fairly big changes.
> 
> I've pulled in the custom Class Loader from Colossus, and then tweaked
> it a bunch.
> 
> This begins to clear up a bunch of problems I've been having getting
> Rails to run under JNLP. These problems are mainly our depending on
> using the local file system. While I'm not quite done yet, this is
> certainly a step in the right direction.
> 
> Additionally, I've deprecated the Util.getStreamFromFile() method.
> Please use ResourceLoader.getInputStream() instead.

Just a question: does this also allow reading from the Rails.jar?
 
> For now, I've updated the relevant areas to use the new 
> method signature
> so that things still compile and function. Next, I'll be removing some
> of the redundancy this new class creates.
> 
> Lastly, thanks to the addition of the game.properties file, 
> I've removed
> reading the local file system to build the game list.

The old version would not have shown a game listed in games.properties,
if the related directory did not actually exist. Now I'm getting
several Exceptions on the console if such a non-existing entry is chosen.
No big deal, but IMO some check should be in place.

One real gripe though: you have also changed the stand-alone utilities
ConvertTilesXML and MakeGameTileSets.
These classes are not really part of the game. 
Running these development aids now requires adding log4j.jar to the
classpath,
and standing the resulting warnings about not having configured log4j
appenders.

I think these utilities do not belong in package rails.util at all.
In fact I vaguely remember that I had them originally in a separate 
tools package. I'm going to put the original versions back there.
If you don't want them there, I can keep these versions local.

Erik.