Re: [Rails-devel] Fixes & sorting

[brett l. <wak...@gm...>]

On 6/24/07, Erik Vos <eri...@hc...> wrote:
> > On 6/23/07, Erik Vos <eri...@hc...> wrote:
> > > > So...  first question I have is in the Game Status
> > window, in the Move
> > > > menu, why are there two undo options?  There's "Undo" and "Undo!".
> > >
> > > The idea is that ultimately players will only be able to
> > > undo their own moves, but the game master will be able to
> > undo everything.
> > > So the whole undo stack is kept, but players can only move between
> > > certain boundaries.
> > > Undo! simulates this master command; for now it is there
> > mainly for testing.
> > > Don't expect it to work everywhere yet.
> > >
> >
> > Ahhh...   how about we relabel it as "Master Undo (for testing)" ?
>
> Hmm, isn't that a bit longish?
> I was inspired by the vi commands that get a forcing character when
> suffixed with a !, for instance q! forces quit where q doesn't.
> I agree that some explanation is needed, perhaps a tooltip?
>


A tooltip would help, but in general having two menu options named the
same thing is going to be confusing.

I don't really see a problem with a long menu option. We're not
limited for space there.


> > > > Last... it looks like there's an issue with
> > Util.getStreamForFile().
> > > > It's not finding any of the images for me.  I'm going to
> > try to debug
> > > > this.
> > >
> > > I have wrestled with that as well. I think the fix was to
> > put all images
> > > in the Rails jar file. Finding property and image files
> > clearly still needs
> > > work.
> > >
> >
> > I found the problem.   there's a leading forward slash on the path
> > name.  it needs to be removed.
>
> Ah, yes, that is what happens if tile.root_directory does not have
> a value in my.properties. I have now made sure that the slash is only
> inserted if that property exists and is not empty.
>

Excellent.   That sounds like a better fix than the one I had come up with.


---Brett