Re: [Rails-devel] Localization (was: Constants)

[brett l. <wak...@gm...>]

On 7/16/06, Erik Vos <eri...@hc...> wrote:
> > Ok... I think I'm more or less done with moving all of the localizable
> > strings out to LocalisedText.properties.
>
> Any particular strategy behind using the different
> key format styles (e.g. LayTile and LAY_TRACK)?
>

No, not really.  Just something that was a byproduct of my doing much
of this without looking at the conventions until I was well into
making the changes.

> > I've also included some helpful text about the conventions used in the
> > file to further help anybody interested in translating.
>
> There is an easier and IMO far better way to format strings
> that contain variable values: MessageFormat.
>
> I have implemented this in LocalText.getText as a new signature
> getText (key, Object[]), where the 2nd arg is an array of objects
> (typically Strings). I have included one example on line 121 of
> LocalisedText.properties, which is used in ORPanel line 802.
>

OK, good.  If I have some time in the next few days, I'll see about
reworking some of the worst offenders of using multiple strings.

> In addition:
>
> - fixed bug 1519026 (Canceling train purchase does not abort
> purchase). This was true for buying from another company, in
> the price request popup.
>
> - implemented request 1517709 (Deactivate train button),
> this applies to train buying if the company has no room
> for more trains.
>
> - fixed a few more bugs around train buying.
>

Excellent.

---Brett.