Re: [Rails-devel] Constants

[John A. T. <ja...@ja...>]

brett lentz wrote:

>I've noticed that we've got a ton of constants that are duplicated
>across our source tree.
>
>Does anyone object to me creating a single Constants class-file that
>holds all of these items and relocating all of our constants into this
>central file?
>  
>
It would seem better to have them related to how they are used, rather 
than just grouping them because they are constants.  For example, a 
constant describing the type of a junction on a tile has no business 
being lumped together with a constant definition of the number of pixels 
offset for some graphic object.

This will add unnecesary coupling between classes.

If the values are really duplicated, then a better solution would be to 
remove the duplication and use one canonical source.

-- 
John A. Tamplin					ja...@ja...
770/436-5387 HOME				4116 Manson Ave
                		 		Smyrna, GA  30082-3723