Re: [Rails-devel] More fixes around tile laying

[brett l. <wak...@gm...>]

On 7/9/06, Erik Vos <eri...@hc...> wrote:
> > 1517705 (reported by Akiyoshi Nomura):
> > If a tile cannot be laid because of lack of money,
> > the tile is still shown on the screen after the error message.
> >
> > Fixed by having the game engine check for valid tile laying
> > in a somewhat earlier stage. This has affected the distribution
> > of work between GUIHex and ORPanel.
>
> The same problem turned out to exist after rejection of
> a Token lay (for instance, for lack of money).
> I fixed this as well.
>
> However, both fixes turned out to have the side effect,
> that the Cancel (No Tile/No Token) button was left disabled.
>
> After this was repaired, I also found an easy fix for
> the disappearance of the upgrade tiles after rotation
> (the fix was simply to skip redrawing the UpgradesPanel).
>
> Brett, I hope, that I'm not crossing any work you have
> been doing on this last problem...
>

It shouldn't so long as you're updating your local copy of the source
tree before making/committing any changes.

> BTW I think that UpgradesPanel is repainted too often.
> But that is not an urgent issue.
>

I agree on both points.  There is plenty of optimization that can be done.

> It seems to me that, however often we rework the whole
> tile/token laying related code, we can't get the whole
> thing transparent enough to lift any work in this area
> above the trial-and-error level. A fresh look is needed.
>

There is certainly room for improvement.

---Brett.