From: Erik V. <eri...@hc...> - 2006-02-05 20:36:40
|
> > See... I have exactly two problems with the side of the fence the > three of you are on... > > 1. The addCash() method is a part of the CashModel, and not the Bank > object. This means that this boolean is for both breaking the bank AND > triggering forced purchase/sale actions for players. > > 2. This is not how the current code works. We've been value checking > things outside of the container classes for a very long time now. If > you look at Bank, CashModel, and Portfolio, you'll see that none of > them do this. > > I do think that the approach you guys are advocating is a sound > approach AND my changes don't disallow it. In fact, it shouldn't be > difficult to use my change as the first step in building the rest of > the bank breaking mechanism. That is what I am doing now, in fact. Just discovered that the criterion is (or can be) game-dependent, although I have not yet seen cases where "runs out" is not used. (I suppose you have followed the discussion in the 18xx group). I make that the default (so the check will become <0). Erik. |