From: Brett L. <wak...@ea...> - 2006-01-10 20:16:44
|
Ok... I've gotten the merged ORWindow working and comitted. It can still use some tweaking to get the sizing correct. Here's an overview of the changes: ORWindow is now just the container class ORPanel is all of the status panel code. MapPanel is MapWindow retooled as a JPanel. UpgradesPanel has been moved out of MapPanel and into ORWindow as one of three main JPanels contained within ORWindow. One lingering issue: Is there a way to find whether there has been an Operating Round or not? ---Brett. -----Original Message----- >From: Brett Lentz <wak...@ea...> >Sent: Jan 9, 2006 6:59 PM >To: rai...@li... >Subject: RE: [Rails-devel] Combining ORWindow and MapWindow > >Well, the nice thing about using the ORWindow as the main container is that the changes are really minimal. Basically, there's little more than changing MapWindow to be a JPanel instead of a JFrame, changing the calls from using contentPane to using the JPanel's add() methods, and adding the mapWindow to ORWindow's constructor. > >The tricky part is, as you mentioned, this changes how the map is made visible, and there's some resizing issues. > >I think I'm going to explore these issues a little further before I commit anything. > > >---Brett. > >-----Original Message----- >>From: Erik Vos <eri...@hc...> >>Sent: Jan 9, 2006 6:14 PM >>To: rai...@li... >>Subject: RE: [Rails-devel] Combining ORWindow and MapWindow >> >>I suppose the OR Window will now become a JPanel, >>that is alternatingly visible and invisible? >> >>There are two reasons why I have some doubts on this move: >>1. The window (panel) sizes will often not match very well, >>2. The OR window currently only exists during an OR, >>whereas the map always exists (though not always visible), >>so that we should be careful about re-initialisation. >> >>On the other hand: I was considering to move, or duplicate, >>the current buttons in the upgrade panel to the OR window. >>Such integration might become easier. >> >>None of my doubts are really prohibitive, so I don't mind trying this, >>but I would prefer to keep the way back open for a while. >> >>Erik. >> >> >>> -----Original Message----- >>> From: rai...@li... >>> [mailto:rai...@li...] On Behalf Of >>> Brett Lentz >>> Sent: 09 January 2006 23:59 >>> To: rails-devel >>> Subject: [Rails-devel] Combining ORWindow and MapWindow >>> >>> I've been looking at how to combine these two windows over >>> the weekend. >>> >>> The easiest method is to add MapWindow to ORWindow rather >>> than the other way around. >>> >>> Currently, I've got a working unified window. There's some >>> resizing issues I'm working out, but overall it works fairly well. >>> >>> However, before I commit the changes... are there any >>> reasons why I should not commit this, just yet? >>> >>> >>> >>> ---Brett. >>> >>> >>> ------------------------------------------------------- >>> This SF.net email is sponsored by: Splunk Inc. Do you grep >>> through log files >>> for problems? Stop! Download the new AJAX search engine that makes >>> searching your log files as easy as surfing the web. >>> DOWNLOAD SPLUNK! >>> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click >>> _______________________________________________ >>> Rails-devel mailing list >>> Rai...@li... >>> https://lists.sourceforge.net/lists/listinfo/rails-devel >>> >>> >> >> >> >> >>------------------------------------------------------- >>This SF.net email is sponsored by: Splunk Inc. Do you grep through log files >>for problems? Stop! Download the new AJAX search engine that makes >>searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! >>http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click >>_______________________________________________ >>Rails-devel mailing list >>Rai...@li... >>https://lists.sourceforge.net/lists/listinfo/rails-devel > > > >------------------------------------------------------- >This SF.net email is sponsored by: Splunk Inc. Do you grep through log files >for problems? Stop! Download the new AJAX search engine that makes >searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! >http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click >_______________________________________________ >Rails-devel mailing list >Rai...@li... >https://lists.sourceforge.net/lists/listinfo/rails-devel |