RE: [Rails-devel] RE: Token laying

[Brett L. <wak...@ea...>]

-----Original Message-----
>From: Erik Vos <eri...@hc...>
>Sent: Dec 26, 2005 6:20 AM
>To: rai...@li...
>Subject: RE: [Rails-devel] RE: Token laying
>
>> Wow.  Now I can see why you got lost.   You've nested the 
>> token laying calls quite deeply.  I think much of this could 
>> be simplified, but for now it works with the one-line change 
>> I've committed.
>> 
>> In PublicCompany.layBaseToken() you were adding the token to 
>> the company, but weren't adding the token to the hex. After 
>> including a call to hex.addToken(), the token is being drawn 
>> on the map.
>
>But still only the very first laid non-home token of any company is shown!
>(I have not mentioned this before, but this was also the case
>with your original token laying code). 
>BTW the station number in the call you added was 1 but should
>have been 0: I got an exception. 
>


Ok... those items are fixable.

It's really a two-part problem.  

1) Are we adding the token to the station?  
2) Are we drawing the tokens in the hex in a way that we can see all tokens?

I'll work on this.


>And the token is still only drawn after "Done" has been pressed.
>My idea was to draw the token as soon as the hex was clicked
>in token laying mode. This would show a "provisional token",
>just as with tile laying, to be replaced with a permanent token
>when Done is pressed. 


I don't think this is quite as necessary as it was with tile placement. Token placement doesn't radically change the look of the board.

I think that as long as we have the selected hex being highlighted to show where the token is going, that ought to be sufficient.


---Brett