Re: [Rails-devel] RE: Token laying

[Brett L. <wak...@ea...>]

I've finally had a chance to look at this batch of updates. (It's been a busy week.)

Some comments:

1. The token laying UI isn't very intuitive.  If I don't want to lay a token, I must press the button labeled "cancel". Perhaps the button should say "Skip Phase" or "No Token" or something else to indicate that token laying isn't mandatory. "Cancel"  just doesn't convey quite the right message, in my mind.

We should also do this for tile laying, which has a similar issue of needing to click 'cancel' if the user doesn't want to play a tile.

Where we SHOULD have a cancel button is to be able to take back the last action. However, I don't want to look at an 'undo' functionality just yet.


2. When I click on a hex to select where to lay a token, the hex isn't being highlighted. We should be highlighting the hex when a user clicks on it.

3. For the token drawing... is it deliberate that it's not currently being drawn, or is it a bug (and should I look into fixing the bug)?

4. For revenue counting, the red, off-map routes have an offMapValue of -1, which makes it difficult to calculate route revenue.

5. Lastly, it's still possible for any player to close any private company, even companies they don't own.


Erik - Is there any of this I should work on, or any specific items I should leave to you?


An additional point to think about:

One thing I noticed in the Colossus code is that there is copious use of AbstractActions (javax.swing.AbstractAction).  These seemed to be a good way of bridging the gap between the UI and the Model. The UI buttons were hooked up to call the AbstractAction, and then within the AbstractAction was the code for executing that game phase.

As our UI code gets more and more complex, perhaps this might be a good way of organizing and simplifying it.


---Brett.



-----Original Message-----
>From: Erik Vos <eri...@hc...>
>Sent: Dec 17, 2005 3:51 PM
>To: rai...@li...
>Subject: [Rails-devel] RE: Token laying
>
>Now fixed. No tokens drawn yet.
>
>I have also done the easy points 2 and 3 on Brett's backlog list:
>phase restrictions on tile laying and private buying.
>
>Erik.
>
>> -----Original Message-----
>> From: Erik Vos [mailto:eri...@hc...] 
>> Sent: 17 December 2005 00:12
>> To: rai...@li...
>> Subject: Token laying
>> 
>> I have committed code to integrate token laying.
>> Most of it is done, except the token drawing.
>> The first token laid is correctly priced.
>> 
>> I'm now getting stuck on the second operating company;
>> I expect that I can sort that out tomorrow. 
>> It must be a minor problem.
>> 
>> Erik.
>> 
>>