Re: [Rails-devel] Status of "bug" 1945690

[brett l. <wak...@gm...>]

On Sun, Dec 7, 2008 at 11:39 AM, Erik Vos <eri...@hc...> wrote:
> I have looked the reported tracked "bug" 1945690 and tried what could be
> done about it.
> Here are the contents after the update I have just made:
>
> [Opened by anonymous:]
> When 5 companies floated in 1851, action buttons are off the screen in
> normal size
>
> [Comment by krazick:]
> This sort of problem will most likely affect more than just 1851, it all
> depends on how many companies are in the game. The List of Companies on the
> Map Window probably should be a scrollable list... and maybe the Action
> Buttons should appear Above the list in a non-scrollable section.
>
> [Just added by me:]
> This problem is at least partly fixed by making the window remember its
> position and height, after it has been repositioned/resized manually (see
> bug fix 1945695).
>
> I have tried to split the screen, so that the division between upper and
> lower part can be manually moved. This allows the lower part to be made
> scrollable. That all works, but I could not find a satisfactory way to set
> the initial pane division so that the result looks good for all games and
> game phases. The result is often ugly, so I have undone all of this.
>
> Not sure if it is worth while to keep this "bug" open; in any case, it is
> unlikely that I will spend any more effort on it.
> [End of bug report]
>
> Since the original Map and OR windows have been merged a few years ago, I
> have been afraid that we would run into such trouble, and indeed I have been
> frequently annoyed by the consequences of this window often being much
> higher than the available screen space. Last week I have made the window
> remember its height, so that it would no longer scroll off the screen at the
> start of each new OR after it has been manually set to a reasonable size.
>
> For me, this has removed most of the trouble I had with the OR window.  Any
> other views?
>
> Erik
>

I haven't tested your changes yet.  I believe that the solution to
this is figuring out what the ideal size for each element in the OR
Window, and having that be used to calculate the minimum size of the
whole window, then using that minimum as the initial window size that
we use.  However, one prerequisite for doing this is having a map that
knows what size it's supposed to be. I don't think that we can improve
the rest of the OR Window much more than we already have until we've
improved on drawing the map.

---Brett.